Apply suggestions from code review
Co-authored-by: Tobias Hagemann <tobias.hagemann@skymatic.de>
This commit is contained in:
parent
af456eb994
commit
c87a37a25a
@ -3,8 +3,8 @@
|
|||||||
|
|
||||||
GOOGLE_PLAYSTORE_PRIVATE_KEY_FILE_PATH=
|
GOOGLE_PLAYSTORE_PRIVATE_KEY_FILE_PATH=
|
||||||
|
|
||||||
SIGNING_KEYSOTRE_PATH=
|
SIGNING_KEYSTORE_PATH=
|
||||||
SIGNING_KEYSOTRE_PASSWORD=
|
SIGNING_KEYSTORE_PASSWORD=
|
||||||
SIGNING_KEY_ALIAS=
|
SIGNING_KEY_ALIAS=
|
||||||
SIGNING_KEY_PASSWORD=
|
SIGNING_KEY_PASSWORD=
|
||||||
|
|
||||||
|
@ -53,7 +53,7 @@ platform :android do |options|
|
|||||||
|
|
||||||
end
|
end
|
||||||
|
|
||||||
desc "Deploy new version to Playstore"
|
desc "Deploy new version to Play Store"
|
||||||
private_lane :deployToPlaystore do |options|
|
private_lane :deployToPlaystore do |options|
|
||||||
deploy_target = "production"
|
deploy_target = "production"
|
||||||
|
|
||||||
@ -69,15 +69,14 @@ platform :android do |options|
|
|||||||
flavor: "playstore",
|
flavor: "playstore",
|
||||||
print_command: false,
|
print_command: false,
|
||||||
properties: {
|
properties: {
|
||||||
"android.injected.signing.store.file" => ENV["SIGNING_KEYSOTRE_PATH"],
|
"android.injected.signing.store.file" => ENV["SIGNING_KEYSTORE_PATH"],
|
||||||
"android.injected.signing.store.password" => ENV["SIGNING_KEYSOTRE_PASSWORD"],
|
"android.injected.signing.store.password" => ENV["SIGNING_KEYSTORE_PASSWORD"],
|
||||||
"android.injected.signing.key.alias" => ENV["SIGNING_KEY_ALIAS"],
|
"android.injected.signing.key.alias" => ENV["SIGNING_KEY_ALIAS"],
|
||||||
"android.injected.signing.key.password" => ENV["SIGNING_KEY_PASSWORD"],
|
"android.injected.signing.key.password" => ENV["SIGNING_KEY_PASSWORD"],
|
||||||
}
|
}
|
||||||
)
|
)
|
||||||
|
|
||||||
upload_to_play_store(
|
upload_to_play_store(
|
||||||
package_name: 'org.cryptomator',
|
|
||||||
track: deploy_target,
|
track: deploy_target,
|
||||||
apk: lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH],
|
apk: lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH],
|
||||||
mapping: lane_context[SharedValues::GRADLE_MAPPING_TXT_OUTPUT_PATH],
|
mapping: lane_context[SharedValues::GRADLE_MAPPING_TXT_OUTPUT_PATH],
|
||||||
@ -103,8 +102,8 @@ platform :android do |options|
|
|||||||
flavor: "apkstore",
|
flavor: "apkstore",
|
||||||
print_command: false,
|
print_command: false,
|
||||||
properties: {
|
properties: {
|
||||||
"android.injected.signing.store.file" => ENV["SIGNING_KEYSOTRE_PATH"],
|
"android.injected.signing.store.file" => ENV["SIGNING_KEYSTORE_PATH"],
|
||||||
"android.injected.signing.store.password" => ENV["SIGNING_KEYSOTRE_PASSWORD"],
|
"android.injected.signing.store.password" => ENV["SIGNING_KEYSTORE_PASSWORD"],
|
||||||
"android.injected.signing.key.alias" => ENV["SIGNING_KEY_ALIAS"],
|
"android.injected.signing.key.alias" => ENV["SIGNING_KEY_ALIAS"],
|
||||||
"android.injected.signing.key.password" => ENV["SIGNING_KEY_PASSWORD"],
|
"android.injected.signing.key.password" => ENV["SIGNING_KEY_PASSWORD"],
|
||||||
}
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user