From c87a37a25a68b78dd2f7485668552e7d11782e2a Mon Sep 17 00:00:00 2001 From: Julian Raufelder Date: Sat, 6 Feb 2021 12:33:19 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Tobias Hagemann --- fastlane/.default.env | 4 ++-- fastlane/Fastfile | 11 +++++------ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/fastlane/.default.env b/fastlane/.default.env index d79b8d49..fe1d804a 100644 --- a/fastlane/.default.env +++ b/fastlane/.default.env @@ -3,8 +3,8 @@ GOOGLE_PLAYSTORE_PRIVATE_KEY_FILE_PATH= -SIGNING_KEYSOTRE_PATH= -SIGNING_KEYSOTRE_PASSWORD= +SIGNING_KEYSTORE_PATH= +SIGNING_KEYSTORE_PASSWORD= SIGNING_KEY_ALIAS= SIGNING_KEY_PASSWORD= diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 6ac8b339..16c926f0 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -53,7 +53,7 @@ platform :android do |options| end - desc "Deploy new version to Playstore" + desc "Deploy new version to Play Store" private_lane :deployToPlaystore do |options| deploy_target = "production" @@ -69,15 +69,14 @@ platform :android do |options| flavor: "playstore", print_command: false, properties: { - "android.injected.signing.store.file" => ENV["SIGNING_KEYSOTRE_PATH"], - "android.injected.signing.store.password" => ENV["SIGNING_KEYSOTRE_PASSWORD"], + "android.injected.signing.store.file" => ENV["SIGNING_KEYSTORE_PATH"], + "android.injected.signing.store.password" => ENV["SIGNING_KEYSTORE_PASSWORD"], "android.injected.signing.key.alias" => ENV["SIGNING_KEY_ALIAS"], "android.injected.signing.key.password" => ENV["SIGNING_KEY_PASSWORD"], } ) upload_to_play_store( - package_name: 'org.cryptomator', track: deploy_target, apk: lane_context[SharedValues::GRADLE_APK_OUTPUT_PATH], mapping: lane_context[SharedValues::GRADLE_MAPPING_TXT_OUTPUT_PATH], @@ -103,8 +102,8 @@ platform :android do |options| flavor: "apkstore", print_command: false, properties: { - "android.injected.signing.store.file" => ENV["SIGNING_KEYSOTRE_PATH"], - "android.injected.signing.store.password" => ENV["SIGNING_KEYSOTRE_PASSWORD"], + "android.injected.signing.store.file" => ENV["SIGNING_KEYSTORE_PATH"], + "android.injected.signing.store.password" => ENV["SIGNING_KEYSTORE_PASSWORD"], "android.injected.signing.key.alias" => ENV["SIGNING_KEY_ALIAS"], "android.injected.signing.key.password" => ENV["SIGNING_KEY_PASSWORD"], }