
11b3a0c2c5db
115412c37195
#explicit zero 1131456ac632
#brk 1158ebc243ea
#random 115323b39f7e
#undefined 116a91d9dddb
#merge 11a042b5a0ba
#vla formatting 119ec639de1b
#pthread 1149571a0a49
#read only 11149cc5ccb8
#zero 112e613ccbe7
#fork mmap 11e239c7dff8
#memprot pthread 110b03d92b7f
#xor 11de08419b82
#junk 11897d4903e2
#guard 11648cd68ca3
#ptrhread guard 110bc4dbcbd2
#stack rand 10aa9cc05d07
10a8cdbb6352
#explicit zero 10b28302c668
#brk 109f8be7d07c
#random 10cb91a7ee3a
#undefined 1008279e2fdd
#merge 106a18bd565d
#vla formatting 102f392c2d08
#pthread 108bbce1bc50
#read only 10725f61db82
#zero 104cd257135f
#fork mmap 109220cf622b
#memprot pthread 108ef71d1ffd
#memprot exit 100eaef1abbd
#xor 1064f1cc2148
#junk 105c42a527cf
#guard 105cc8c34e60
#pthread guard 107f61cc8a1c
#stack rand 9abdf523d26
9e4b9b31e6f
#explicit zero 9a3a22a63d2
#brk 97444dbc3cf
#random 9dcd3b72ac9
#undefined 9543e1df342
#merge 9611e5691f7
#vla formatting 98de97ce864
#pthread 9a475717042
#read only 97f0947cc0e
#zero 9e9751d3370
#fork mmap 983cd86d0d5
#memprot pthread 91ebb165455
#memprot exit 9488ba483cf
#xor 9f9351d884b
#junk 985e5bca0a5
#move Signed-off-by: Tad <tad@spotco.us>
40 lines
1.3 KiB
Diff
40 lines
1.3 KiB
Diff
From 6a18bd565d9344db5f46f2bb423309dcb134be6e Mon Sep 17 00:00:00 2001
|
|
From: Daniel Micay <danielmicay@gmail.com>
|
|
Date: Sat, 16 Jul 2016 23:55:16 -0400
|
|
Subject: [PATCH] replace VLA formatting buffer with dprintf
|
|
|
|
---
|
|
libc/bionic/bionic_systrace.cpp | 10 +---------
|
|
1 file changed, 1 insertion(+), 9 deletions(-)
|
|
|
|
diff --git a/libc/bionic/bionic_systrace.cpp b/libc/bionic/bionic_systrace.cpp
|
|
index 6182ed801c..ccb15a9959 100644
|
|
--- a/libc/bionic/bionic_systrace.cpp
|
|
+++ b/libc/bionic/bionic_systrace.cpp
|
|
@@ -26,8 +26,6 @@
|
|
|
|
#include <cutils/trace.h> // For ATRACE_TAG_BIONIC.
|
|
|
|
-#define WRITE_OFFSET 32
|
|
-
|
|
static Lock g_lock;
|
|
static CachedProperty g_debug_atrace_tags_enableflags("debug.atrace.tags.enableflags");
|
|
static uint64_t g_tags;
|
|
@@ -61,15 +59,9 @@ void bionic_trace_begin(const char* message) {
|
|
return;
|
|
}
|
|
|
|
- // If bionic tracing has been enabled, then write the message to the
|
|
- // kernel trace_marker.
|
|
- int length = strlen(message);
|
|
- char buf[length + WRITE_OFFSET];
|
|
- size_t len = snprintf(buf, length + WRITE_OFFSET, "B|%d|%s", getpid(), message);
|
|
-
|
|
// Tracing may stop just after checking property and before writing the message.
|
|
// So the write is acceptable to fail. See b/20666100.
|
|
- TEMP_FAILURE_RETRY(write(trace_marker_fd, buf, len));
|
|
+ dprintf(trace_marker_fd, "B|%d|%s", getpid(), message);
|
|
}
|
|
|
|
void bionic_trace_end() {
|