AtaraxiaDev/cryptomator-android
1
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Simplify exists check in CloudImpls:write

Browse Source 
Switching if (exists(file) && !replace) to  if (!replace && exists(file))
This commit is contained in:
Julian Raufelder 2021-04-07 15:40:57 +02:00
parent 932ea09b62
commit 6df05fd95b
No known key found for this signature in database
GPG Key ID: 17EE71F6634E381D
6 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
data/src/main/java/org/cryptomator/data/cloud/dropbox/DropboxImpl.java
View File

@ -195,7 +195,7 @@ class DropboxImpl {
} }
public DropboxFile write(DropboxFile file, DataSource data, final ProgressAware<UploadState> progressAware, boolean replace, long size) throws AuthenticationException, DbxException, IOException, CloudNodeAlreadyExistsException { public DropboxFile write(DropboxFile file, DataSource data, final ProgressAware<UploadState> progressAware, boolean replace, long size) throws AuthenticationException, DbxException, IOException, CloudNodeAlreadyExistsException {
if (exists(file) && !replace) { if (!replace && exists(file)) {
throw new CloudNodeAlreadyExistsException("CloudNode already exists and replace is false"); throw new CloudNodeAlreadyExistsException("CloudNode already exists and replace is false");
} }

2
data/src/main/java/org/cryptomator/data/cloud/local/file/LocalStorageImpl.java
View File

@ -140,7 +140,7 @@ class LocalStorageImpl {
} }
public LocalFile write(final CloudFile file, DataSource data, final ProgressAware<UploadState> progressAware, boolean replace, final long size) throws IOException, BackendException { public LocalFile write(final CloudFile file, DataSource data, final ProgressAware<UploadState> progressAware, boolean replace, final long size) throws IOException, BackendException {
if (exists(file) && !replace) { if (!replace && exists(file)) {
throw new CloudNodeAlreadyExistsException("CloudNode already exists and replace is false"); throw new CloudNodeAlreadyExistsException("CloudNode already exists and replace is false");
} }

2
data/src/main/java/org/cryptomator/data/cloud/local/storageaccessframework/LocalStorageAccessFrameworkImpl.java
View File

@ -427,7 +427,7 @@ class LocalStorageAccessFrameworkImpl {
progressAware.onProgress(Progress.started(UploadState.upload(file))); progressAware.onProgress(Progress.started(UploadState.upload(file)));
Optional<Uri> fileUri = existingFileUri(file); Optional<Uri> fileUri = existingFileUri(file);
if (fileUri.isPresent() && !replace) { if (!replace && fileUri.isPresent()) {
throw new CloudNodeAlreadyExistsException("CloudNode already exists and replace is false"); throw new CloudNodeAlreadyExistsException("CloudNode already exists and replace is false");
} }

2
data/src/main/java/org/cryptomator/data/cloud/onedrive/OnedriveImpl.java
View File

@ -242,7 +242,7 @@ class OnedriveImpl {
} }
public OnedriveFile write(final OnedriveFile file, DataSource data, final ProgressAware<UploadState> progressAware, boolean replace, final long size) throws BackendException { public OnedriveFile write(final OnedriveFile file, DataSource data, final ProgressAware<UploadState> progressAware, boolean replace, final long size) throws BackendException {
if (exists(file) && !replace) { if (!replace && exists(file)) {
throw new CloudNodeAlreadyExistsException("CloudNode already exists and replace is false"); throw new CloudNodeAlreadyExistsException("CloudNode already exists and replace is false");
} }

2
data/src/main/java/org/cryptomator/data/cloud/webdav/WebDavImpl.java
View File

@ -138,7 +138,7 @@ class WebDavImpl {
public WebDavFile write(final WebDavFile uploadFile, DataSource data, final ProgressAware<UploadState> progressAware, boolean replace, final long size) // public WebDavFile write(final WebDavFile uploadFile, DataSource data, final ProgressAware<UploadState> progressAware, boolean replace, final long size) //
throws BackendException, IOException { throws BackendException, IOException {
if (exists(uploadFile) && !replace) { if (!replace && exists(uploadFile)) {
throw new CloudNodeAlreadyExistsException("CloudNode already exists and replace is false"); throw new CloudNodeAlreadyExistsException("CloudNode already exists and replace is false");
} }

2
data/src/notFoss/java/org/cryptomator/data/cloud/googledrive/GoogleDriveImpl.java
View File

@ -255,7 +255,7 @@ class GoogleDriveImpl {
public GoogleDriveFile write(final GoogleDriveFile file, DataSource data, final ProgressAware<UploadState> progressAware, boolean replace, final long size) // public GoogleDriveFile write(final GoogleDriveFile file, DataSource data, final ProgressAware<UploadState> progressAware, boolean replace, final long size) //
throws IOException, BackendException { throws IOException, BackendException {
if (exists(file) && !replace) { if (!replace && exists(file)) {
throw new CloudNodeAlreadyExistsException("CloudNode already exists and replace is false"); throw new CloudNodeAlreadyExistsException("CloudNode already exists and replace is false");
} }